cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...
Date Mon, 03 Oct 2016 17:17:07 GMT
GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159

    CB-11926 Tests can use local server

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    All
    
    ### What does this PR do?
    Allows tests to use a locally deployed server. You can specify its address via `--variable
FILETRANSFER_SERVER_ADDRESS=http://your.address.here:5000` upon plugin installation.
    The server itself can be found at:
    https://github.com/apache/cordova-labs/tree/cordova-filetransfer
    However, it's easier to just use paramedic, which can deploy this server and patch the
tests to use it automatically:
    https://github.com/apache/cordova-paramedic/pull/17
    
    ### What testing has been done on this change?
    Tested w/ and w/o paramedic on Android and Windows platforms.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-file-transfer local-server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit ca293bd3f29dc74f628721a552ff91593380d81e
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-09-30T16:20:41Z

    CB-11926 Tests can use local server

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message