cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From baboring <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #142: android doesn't support data to s...
Date Sun, 30 Oct 2016 01:45:01 GMT
GitHub user baboring opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/142

    android doesn't support data to save photo for contact by image data …

    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    Fixes a problem that is not supported to save data base64 to be able to save for contact
photo.
    
    ### What testing has been done on this change?
    
    Tested on Samsung Galaxy Note3, Android 4.4 Emulator
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [O] Added automated test coverage as appropriate for this change.
    
    PS
     This is not my own source code but I think anyone didn't reflect this solution for it.

     I referred it from https://groups.google.com/forum/#!msg/phonegap/jTMu9Azjaa8/ywQMMEcoS1YJ.
     I just wanted to fix this issue. That's why I am doing this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/baboring/cordova-plugin-contacts master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 92d5bbe79f6fb49e69acd38fc5c3f197e347c0c2
Author: Benjamin <baboring@gmail.com>
Date:   2016-10-30T00:59:19Z

    android doesn't support data to save photo for contact by image data base64 encoded

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message