cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera issue #240: Added NSPhotoLibraryUsageDescription param...
Date Sun, 30 Oct 2016 13:22:45 GMT
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-plugin-camera/pull/240
  
    Hi.
    Thanks for the PR!
    
    I have created a new issue for this https://issues.apache.org/jira/browse/CB-12086, can
you change the title to start with CB-12086 so it's linked?
    
    There are some other references to `NSPhotoLibraryUsageDescriptionentry` that should be
changed to `NSPhotoLibraryUsageDescription`, can you do it? 
    And format the `PHOTOLIBRARY_USAGE_DESCRIPTION for NSPhotoLibraryUsageDescriptionentry`
line correctly so it looks like the `CAMERA_USAGE_DESCRIPTION for NSCameraUsageDescription`
line
    
    Also, on camera plugin the docs are generated using jsdoc to markdown, so the file you
have to edit is https://github.com/apache/cordova-plugin-camera/blob/master/jsdoc2md/TEMPLATE.md,
not the README.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message