cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosov-nikita <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #203: CB-11933: Add uap prefixes for capabiliti...
Date Thu, 20 Oct 2016 09:49:29 GMT
Github user matrosov-nikita commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/203#discussion_r84247927
  
    --- Diff: spec/unit/ConfigChanges.spec.js ---
    @@ -57,24 +57,28 @@ describe('PlatformMunger', function () {
     
             it('should call parent\'s method with the same parameters', function () {
                 munger.apply_file_munge(WINDOWS_MANIFEST, munge, false);
    -            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalled();
    +            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalledWith(WINDOWS_MANIFEST,
munge, false);
             });
     
             it('should additionally call parent\'s method with another munge if removing
changes from windows 10 appxmanifest', function () {
                 munger.apply_file_munge(WINDOWS10_MANIFEST, munge, /*remove=*/true);
    -            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalled();
    -            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalled();
    +            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalledWith(WINDOWS10_MANIFEST,
munge, true);
    +            expect(BaseMunger.prototype.apply_file_munge).toHaveBeenCalledWith(WINDOWS10_MANIFEST,
jasmine.any(Object), true);
    --- End diff --
    
    @daserge, I've removed this check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message