cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...
Date Thu, 20 Oct 2016 06:40:23 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -68,9 +68,13 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 if (result[2])
                     options.subdir = result[2];
                 //if --fetch was used, throw error for subdirectories
    -            if (result[2] && options.fetch) {
    -                return Q.reject(new CordovaError('--fetch does not support subdirectories'));
    -            }
    +        if(options.subdir) {
    +            events.emit('warn', 'support for subdirectories is depreated and will be
removed in Cordova@7');
    +        if (options.fetch) {
    --- End diff --
    Probably an Indentation issue? This should has the same level of indentation as line above

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message