cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sfrank87 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser issue #101: CB-8467 provide hide method to hide ...
Date Wed, 19 Oct 2016 08:27:01 GMT
Github user sfrank87 commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/101
  
    Hi.
    Thank you very much for your effort. :)
    
    I found an misstake in [CDVInAppBrowser.m](https://github.com/herrevilkitten/cordova-plugin-inappbrowser/blob/df8bcaf7515569733704fe780402f9123a60d61d/src/ios/CDVInAppBrowser.m).
The hide method was implemented twice, in line 246 and in line 270. ^^"
    
    However, I wonder what's wrong with the android build. After all, the hide implementation
is an exact copy of show, except for two words. (i diffed both sections, seems no misstakes).
And the [Jenkins log](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/PLATFORM=android/56/console)
seems a bit strange, too. For me, it’s a bit conspicuous that it says “no workspace”.
O.o
    
    regards
    Frank


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message