cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <>
Subject [GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...
Date Tue, 18 Oct 2016 23:48:00 GMT
Github user stevengill commented on a diff in the pull request:
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 //if --fetch was used, throw error for subdirectories
                 if (result[2] && options.fetch) {
                     return Q.reject(new CordovaError('--fetch does not support subdirectories'));
    +            } else {
    +                if(result[2]) {
    +                    events.emit('warn', 'support for subdirectories is depreated and
will be removed in Cordova@7');
    +                }
    --- End diff --
    so, if fetch and subdir -> fail, if subdir && no fetch -> do deprecation
notice. If we move it up, users who are using --fetch get deprecation warning & failure.
That would be acceptable too. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message