cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #504: CB-11979 added deprecation warning for subdir...
Date Tue, 18 Oct 2016 23:46:17 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/504#discussion_r83974283
  
    --- Diff: cordova-lib/src/plugman/fetch.js ---
    @@ -70,6 +70,10 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
                 //if --fetch was used, throw error for subdirectories
                 if (result[2] && options.fetch) {
                     return Q.reject(new CordovaError('--fetch does not support subdirectories'));
    +            } else {
    +                if(result[2]) {
    +                    events.emit('warn', 'support for subdirectories is depreated and
will be removed in Cordova@7');
    +                }
    --- End diff --
    
    if fetch and subdirectory are both present, it will just do a straight reject return Q.reject(new
CordovaError('--fetch does not support subdirectories'));


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message