cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes
Date Tue, 18 Oct 2016 22:12:39 GMT
Github user jcesarmobile commented on the issue:

    https://github.com/apache/cordova-ios/pull/269
  
    We where using canOpenURL on inAppBrowser plugin, but I removed it to fix CB-11178 as
we weren't really sending any response to the user if canOpenURL was false.
    
    I don't think it's a good idea to add all the allow-intent schemes into the LSApplicationQueriesSchemes,
as not all are needed to be there (as http or https), also, the PR doesn't handle the case
of a duplicate scheme, as you can put multiple urls starting by http in allow intent tags
and this will add http protocol multiple times.
    
    As we are going to allow to write into the info.plist from the config.xml soon, and we
don't use canOpenURL on cordova-ios, I don't think this should be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message