cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From giuseppelt <...@git.apache.org>
Subject [GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Date Tue, 18 Oct 2016 14:22:35 GMT
Github user giuseppelt commented on the issue:

    https://github.com/apache/cordova-windows/pull/196
  
    This patch doesn't touch nothing, nor alter the manifest.
    It's just a logic check, because the previous code assumes the node is always found.
    The code simply is `if (node != null) ...dologic` nothing more than that.
    The assumption is wrong, because you can have a manifest (WP8.1) without splashscreen
node.
    
    Manifest without the splashscreen node: --> Exception.
    Manifest with the node: --> run as usual.
    
    This patch is just a logic check, no omission, no something else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message