cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <>
Subject [GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...
Date Fri, 07 Oct 2016 14:37:33 GMT
Github user alsorokin commented on a diff in the pull request:
    --- Diff: bin/templates/cordova/Api.js ---
    @@ -212,6 +212,11 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
           installOptions.android_studio = true;
    +    //CB-11964: Do a clean when installing the plugin code to get around
    +    //the Gradle bug introduced by the Android Gradle Plugin Version 2.2
    +    //TODO: Delete when the next version of Android Gradle plugin comes out
    +    this.clean();
    --- End diff --
    Is it out of promise chain intentionally? I think that `this.clean()` returns a promise.
    I've tried to merge it to the promise chain, but got the following exception upon `cordova
platform add`:
    Error: ENOENT: no such file or directory, open 'C:\Cordova\foo\platforms\android\assets\www\cordova_plugins.js'
        at Error (native)
        at Object.fs.openSync (fs.js:549:18)
        at Object.fs.writeFileSync (fs.js:1156:15)
        at C:\Cordova\foo\platforms\android\cordova\node_modules\cordova-common\src\PluginManager.js:137:12
        at _fulfilled (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:834:54)
        at self.promiseDispatch.done (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:863:30)
        at Promise.promise.promiseDispatch (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:796:13)
        at C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:857:14
        at runSingle (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:137:13)
        at flush (C:\Cordova\foo\platforms\android\cordova\node_modules\q\q.js:125:13)
    I wonder why it works the way you put it and if it is dangerous to leave it like this.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message