cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-android pull request #339: CB-11964: Do a clean when installing a pl...
Date Fri, 07 Oct 2016 14:37:33 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/339#discussion_r82400883
  
    --- Diff: bin/templates/cordova/Api.js ---
    @@ -349,13 +354,24 @@ Api.prototype.run = function(runOptions) {
      */
     Api.prototype.clean = function(cleanOptions) {
         var self = this;
    +    try {
    --- End diff --
    
    I think instead of doing this `try catch` in product code we could just mock `Api.prototype.clean()`
in tests. Please see my attempt at doing so:
    https://github.com/alsorokin/cordova-android/commit/008f46a1f3e807ee0ec1b576cd1a5d84e779d838


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message