cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-coho pull request #141: CB-9157: Added copy-js command to copy an up...
Date Tue, 04 Oct 2016 18:52:22 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/141#discussion_r81827457
  
    --- Diff: src/platform-release.js ---
    @@ -59,6 +59,36 @@ function cpAndLog(src, dest) {
         }
     }
     
    +/* 
    + * A function that handles version if it is defined or undefined
    + *
    + * @param {String} repo                    current repo
    + * @param {String|undefined} ver           current version that can be defined or undefined
    + * @param {String|undefined} validate      current version that can be defined or undefined
    + *
    + * @return {String} version                Returns the calculated version
    + *
    + */
    +
    +function *handleVersion(repo,ver,validate) {
    +    var platform = repo.id;
    +    var version = ver || undefined;
    +
    +    if (version === undefined) {
    +        yield repoutil.forEachRepo([repo], function*() {
    +            // Grabbing version from platformPackageJson
    +            var platformPackage = path.join(process.cwd(), 'package.json');
    +            var platformPackageJson = require(platformPackage);
    +        if(validate === true) {
    --- End diff --
    
    This if/else should be tabbed as it is inside the `forEachRepo` block


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message