cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...
Date Tue, 04 Oct 2016 07:29:42 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: tests/hooks/after_prepare.js ---
    @@ -0,0 +1,71 @@
    +#!/usr/bin/env node
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements.  See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership.  The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License.  You may obtain a copy of the License at
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* KIND, either express or implied.  See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +var path = require('path');
    +var fs = require('fs');
    +module.exports = function(context) {
    +    function main() {
    +        // get the file transfer server address from the specified variables
    +        var defaultFileTransferServerAddress = getDefaultFileTransferServerAddress(context);
    --- End diff --
    I think you can optimize this a bit by calling `getDefaultFileTransferServerAddress()`
only when server address is not set explicitly:
    var fileTransferServerAddress = getFileTransferServerAddress(context) ||

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message