cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #159: CB-11926 Tests can use local...
Date Tue, 04 Oct 2016 07:29:42 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159#discussion_r81697958
  
    --- Diff: tests/hooks/after_prepare.js ---
    @@ -0,0 +1,71 @@
    +#!/usr/bin/env node
    +
    +/*
    +*
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements.  See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership.  The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License.  You may obtain a copy of the License at
    +*
    +*   http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +* KIND, either express or implied.  See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +*
    +*/
    +
    +var path = require('path');
    +var fs = require('fs');
    +
    +module.exports = function(context) {
    +    function main() {
    +        // get the file transfer server address from the specified variables
    +        var defaultFileTransferServerAddress = getDefaultFileTransferServerAddress(context);
    +        var fileTransferServerAddress = getFileTransferServerAddress(context) || defaultFileTransferServerAddress;
    +        console.log('Tests will use the following file transfer server address: ' + fileTransferServerAddress);
    +
    +        // pass it to the tests
    +        writeFileTransferOptions(fileTransferServerAddress, context);
    +    }
    +
    +    function getDefaultFileTransferServerAddress(context) {
    --- End diff --
    
    I'm curious whether this function is needed. If there is a default value for variable
and user didn't override it via CLI parameter, isn't the default value being written to `<platform>.json`
file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message