cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...
Date Sat, 01 Oct 2016 00:31:43 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/257#discussion_r81437971
  
    --- Diff: bin/templates/scripts/cordova/lib/build.js ---
    @@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) {
             events.emit('log','\tConfiguration: ' + configuration);
             events.emit('log','\tPlatform: ' + (buildOpts.device ? 'device' : 'emulator'));
     
    -        var xcodebuildArgs = getXcodeArgs(projectName, projectPath, configuration, buildOpts.device);
    +        var xcodebuildArgs = getXcodeBuildArgs(projectName, projectPath, configuration,
buildOpts.device);
             return spawn('xcodebuild', xcodebuildArgs, projectPath);
         }).then(function () {
             if (!buildOpts.device || buildOpts.noSign) {
                 return;
             }
    +
    +        var exportOptions = {'compileBitcode': false};
    +
    +        if (buildOpts.packageType) {
    +            exportOptions.method = buildOpts.packageType;
    --- End diff --
    
    Yeah we should. I just tested it, and it works with that default. Must be an xcodebuild
bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message