cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <>
Subject [GitHub] cordova-plugin-geolocation pull request #81: CB-11875 added android.hardware...
Date Thu, 22 Sep 2016 22:17:56 GMT
GitHub user audreyso opened a pull request:

    CB-11875 added android.hardware.location.gps uses-feature.

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Fixes feature issue (geolocation)
    ### What testing has been done on this change?
    Tested that <uses-feature android:name="android.hardware.location.gps" />  got added
to Android manifest; Ran and tested that geolocation worked on Android device.
    ### Checklist
    - [ ] [ICLA]( has been signed and submitted to
    - [X] [Reported an issue]( in the JIRA
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-11875

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
commit 01dd58f7a607917736e92a01345a06a4fd643ea4
Author: Audrey So <>
Date:   2016-09-22T22:07:50Z

    CB-11875 added android.hardware.location.gps uses-feature.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message