cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tobiasviehweger <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #64: CB-11858: Add possibility to util...
Date Fri, 16 Sep 2016 07:14:07 GMT
GitHub user tobiasviehweger opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/64

    CB-11858: Add possibility to utilize Android M feature "LightStatusBar"

    ### Platforms affected
    Android 6.0+
    
    ### What does this PR do?
    This PR adds support for the LightStatusBar style in Android. I re-used the already existing
config "StatusBarStyle" for this, as it has a similar effect on iOS (changing the foreground
color of the status bar to black instead of white).
    
    Something I'd like to discuss is, if "lightcontent" is the correct default value. The
documentation says it is, but I don't think it actually is on iOS, is it? I think the iOS
default is actually blackopaque?
    
    Let me know what you think :)
    
    ### What testing has been done on this change?
    Tested in emulator & on Samsung Galaxy S7.
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sovanta/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 5ff4e56a921c2cd45a64a65505a21be66ec644c4
Author: Tobias Viehweger <tobias.viehweger@gmail.com>
Date:   2016-09-15T15:34:45Z

    CB-11858: Add possibility to utilize Android M feature "LightStatusBar"

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message