cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #492: CB-11908 Add edit-config to config.xml
Date Mon, 26 Sep 2016 21:29:50 GMT
GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-lib/pull/492

    CB-11908 Add edit-config to config.xml

    Handles edit-config for config.xml. 
    
    Fixed up the conflict checking so that config.xml will take precedence over plugin.xml
changes. 
    Added a remove mode to config.xml only, explained more below. 
    
    To test out these changes, remember to copy it to the platform's cordova-common. 
    
    A couple things to discuss/clarify:
    1. These changes will make config.xml changes take precedence over plugin.xml changes
even if --force is used. Is this alright? Or should --force actually force add the plugin
anyways? 
    
    2. There's no real way to "undo" edit-config changes in config.xml. As a fix, I've added
a "remove" mode that will remove the attributes specified. Do you think this is useful to
have? There's no such thing as restoring/reverting the xml elements to what they were before.
What was initially the old list of attributes from before the edit-config change will get
overwritten on every prepare. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-lib editconfigxml

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/492.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #492
    
----
commit d0ce4c506d2f7f24bda145e21f9b9af1543b1ecd
Author: ktop <ktop500@gmail.com>
Date:   2016-09-26T21:07:09Z

    CB-11908 Add edit-config to config.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message