cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosovN <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #195: CB-11848 windows: Remove duplicate sl...
Date Wed, 21 Sep 2016 08:26:58 GMT
GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/195

    CB-11848 windows: Remove duplicate slash after file system path

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    As we have always trailing slash after file system path we get invalid URI, for example
ms-appdata:///temp//myfile.file, therefore we needn't leading slash in path argument. This
PR removes it.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11848

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
    
----
commit 35b7a25f9f1b469daca7386a85f9eb68b82110b9
Author: Nikita Matrosov <nikita.matrosov@rp.ru>
Date:   2016-09-20T11:07:56Z

    CB-11848 windows: Remove duplicate slash after file system path
    
    As we have always trailing slash after file system path we get invalid URI, for example
ms-appdata:///temp//myfile.file, therefore we needn't leading slash in path argument

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message