cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosovN <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #188: CB-11694 Android: Set hadware...
Date Wed, 21 Sep 2016 08:32:34 GMT
GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/188

    CB-11694 Android: Set hadwareBackButton value according option in cor…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    HadwareBackButton value persists across usages. By default hardwareBack value is null.
In this case we should set hadwareBackButton  to default value.
    
    ### What testing has been done on this change?
    Manual test
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-inappbrowser CB-11694

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #188
    
----
commit 71cf378af0a111e94fa4c94f2deb092ca65d3cf4
Author: Nikita Matrosov <nikita.matrosov@rp.ru>
Date:   2016-09-20T07:23:37Z

    CB-11694 Android: Set hadwareBackButton value according option in cordova.InAppBrowser.open
    
    HadwareBackButton value persists across usages. By default hardwareBack value is null.
In this case we should set hadwareBackButton  to default value.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message