cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lexaurin <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #186: CB-11946: window.open mailto:...
Date Wed, 14 Sep 2016 12:55:53 GMT
GitHub user lexaurin opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/186

    CB-11946: window.open mailto: consistency

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android and WP
    
    ### What does this PR do?
    Fixes mailto links opening with window.open()
    
    ### What testing has been done on this change?
    Tested in emulator.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    Fixed opening mailto: links on Android and WP and tel: on WP, for consistency.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/saphocom/cordova-plugin-inappbrowser cb-11846

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 6fc55bc7bf25a155bf5c1e9d5de155364e778d82
Author: Lex Mourek <lex@mourek.name>
Date:   2016-09-14T12:48:15Z

    CB-11946: window.open mailto: consistency
    
    Fixed opening mailto: links on Android and WP and tel: on WP, for consistency.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message