cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dmvjs <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #185: iOS friendlier UI
Date Sun, 04 Sep 2016 01:22:40 GMT
GitHub user dmvjs opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/185

    iOS friendlier UI

    https://issues.apache.org/jira/browse/CB-11804
    inappbrowser plugin for ios doesnt look consistent with iOS style
    
    ### Platforms affected
    iOS only
    
    ### What does this PR do?
    makes the UI more iOS friendly
    
    ### What testing has been done on this change?
    I have been using this UI for over three years in several apps for a large publisher.
it's a UI change but it makes a big difference IMO
    
    ### Checklist
    - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [0 ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [0 ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dmvjs/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #185
    
----
commit 424e838d21cd1c00f2393eebdc090a8e0e3a3576
Author: Kirk Elliott <kirk@addthis.com>
Date:   2016-09-04T01:07:52Z

    iOS friendlier UI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message