cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosov-nikita <>
Subject [GitHub] cordova-plugin-contacts pull request #138: Add extra labels for phone, ims
Date Fri, 30 Sep 2016 06:44:26 GMT
GitHub user matrosov-nikita opened a pull request:

    Add extra labels for phone, ims

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Refactor converting methods. Add posibility to use default labels: 'home fax', 'work fax'
    ### What testing has been done on this change?
    Auto test
    ### Checklist
    - [x] [ICLA]( has been signed and submitted to
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-11541

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
commit d395b0a787bc6e4bb5525cd07fafe8e878965dbc
Author: Nikita Matrosov <>
Date:   2016-09-30T06:39:24Z

    Add extra labels for phone, ims
    Refactor converting methods. Add posibility to use default labels: 'home fax', 'work fax'


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message