cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosovN <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #136: CB-11028 android: Allow to set cu...
Date Mon, 26 Sep 2016 09:25:09 GMT
GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/136

    CB-11028 android: Allow to set custom labels for contacts' fields

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    It was not possible before to retrieve the value of custom field's label (e.g. 'My phone').
The returned contact was always containing  for such fields. This updates Android implementation
to return custom label's value rather than custom similar to iOS.
    
    ### What testing has been done on this change?
    Auto test
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-contacts CB-11028

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit 200f1fdd9d69bdad2c3d4c315f6c4bc40159ae6e
Author: Nikita Matrosov <matrosov.nikita94@gmail.com>
Date:   2016-09-26T09:22:13Z

    CB-11028 android: Allow to set custom labels for contacts' fields
    
    It was not possible before to retrieve the value of custom field's label (e.g. 'My phone').
The returned contact was always containing  for such fields. This updates Android implementation
to return custom label's value rather than custom similar to iOS.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message