cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From soonahn <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #134: CB-11855: (ios) Allow iOS to use ...
Date Thu, 15 Sep 2016 06:52:11 GMT
GitHub user soonahn opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/134

    CB-11855: (ios) Allow iOS to use hasPhoneNumber

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Fixes https://issues.apache.org/jira/browse/CB-11855
    
    ### What testing has been done on this change?
    Tested on iOS 9.3 - iPhone 6.  As well as iOS Simulator of iPhone 6S
    
    ### Checklist
    - [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted
to secretary@apache.org.
    - [ Yes ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the
JIRA database
    - [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving
file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ No ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soonahn/cordova-plugin-contacts allow_ios_to_filter_for_phone_number_only

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 85b52d354caeb41ed79269cc9dce690ef41917c8
Author: Justin Ahn <justin@soonahn.ca>
Date:   2016-09-15T06:39:33Z

    Capturing the default like the multiple option, and then continuing through the array
if there are no phone numbers for the user

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message