cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julio cesar sanchez <jcesarmob...@gmail.com>
Subject Re: [Discuss] plugins release
Date Wed, 14 Sep 2016 18:31:12 GMT
I don't think we fixed all the plugins for iOS 10, only contacts, camera
and media-capture, but probably others might crash
Do you still need a vote or 3 are enough?

2016-09-14 20:13 GMT+02:00 Steven Gill <stevengill97@gmail.com>:

> Need one more! It is important to get these out asap. Getting contacted
> about certain plugins not working on ios10 already!
>
>
>
> On Tue, Sep 13, 2016 at 3:30 PM, Steven Gill <stevengill97@gmail.com>
> wrote:
>
> > Bump! Please vote on the release
> >
> > On Thu, Sep 8, 2016 at 9:06 AM, Steven Gill <stevengill97@gmail.com>
> > wrote:
> >
> >> I can review and merge
> >>
> >> On Sep 8, 2016 9:00 AM, "David Barth" <david.barth@canonical.com>
> wrote:
> >>
> >>> Hey guys,
> >>>
> >>> Alex has a set of fixes for ubuntu code in the following plugins:
> >>>
> >>>    - https://github.com/apache/cordova-plugin-inappbrowser/pull/174
> >>>    - https://github.com/apache/cordova-plugin-battery-status/pull/38
> >>>    - https://github.com/cordova-ubuntu/cordova-plugin-
> geolocation/pull/2
> >>>
> >>> Should we get another review from plugin maintainers or should i merge
> to
> >>> get that in time for the release ?
> >>>
> >>> David
> >>>
> >>>
> >>>
> >>> On Wed, Sep 7, 2016 at 4:47 PM, julio cesar sanchez <
> >>> jcesarmobile@gmail.com>
> >>> wrote:
> >>>
> >>> > Or maybe we should wait for the corodvaDependencies update? I think
> >>> there
> >>> > are PRs for all the plugins
> >>> >
> >>> > 2016-09-07 16:21 GMT+02:00 Steven Gill <stevengill97@gmail.com>:
> >>> >
> >>> > > Yes. I'll move forward with it
> >>> > >
> >>> > > On Sep 7, 2016 6:25 AM, "julio cesar sanchez" <
> >>> jcesarmobile@gmail.com>
> >>> > > wrote:
> >>> > >
> >>> > > > Issues won't stop coming, should we do the release this week?
> >>> > > >
> >>> > > > 2016-08-29 13:26 GMT+02:00 Kerri Shotts <kerrishotts@gmail.com>:
> >>> > > >
> >>> > > > > I've got iPads that support multitasking, so I'll take
a look.
> >>> > > > >
> >>> > > > > ~ Kerri
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > > On Mon, Aug 29, 2016 at 5:57 AM -0500, "julio cesar
sanchez" <
> >>> > > > > jcesarmobile@gmail.com> wrote:
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > > If somebody with an iPad that supports multitasking
can test
> this
> >>> > PR...
> >>> > > > > https://github.com/apache/cordova-plugin-statusbar/pull/62
> >>> > > > >
> >>> > > > > I have reviewed the code and looks good, bud I don't
have an
> iPad
> >>> > that
> >>> > > > > supports multitasking to test it, and I don't trust
the
> >>> simulator in
> >>> > > this
> >>> > > > > case as I tried to fix that issue in a different way,
got it
> >>> working
> >>> > on
> >>> > > > the
> >>> > > > > simulator but the reporter said that it didn't work
as expected
> >>> on a
> >>> > > real
> >>> > > > > device.
> >>> > > > >
> >>> > > > > 2016-08-25 0:54 GMT+02:00 julio cesar sanchez :
> >>> > > > >
> >>> > > > > > PRs to review
> >>> > > > > > https://github.com/apache/cordova-plugin-contacts/pull/131
> >>> > > > > > https://github.com/apache/cordova-plugin-camera/pull/229
> >>> > > > > >
> >>> > > > > > 2016-08-24 20:20 GMT+02:00 Steven Gill :
> >>> > > > > >
> >>> > > > > >> Hey Scott,
> >>> > > > > >>
> >>> > > > > >> Thanks for pointing out the PR. I'll take a
look.
> >>> > > > > >>
> >>> > > > > >> The reality of the situation is that cordova
has many repos
> >>> and
> >>> > not
> >>> > > > > enough
> >>> > > > > >> committers currently. This leads to PRs sitting
unreviewed.
> >>> Plugin
> >>> > > PRs
> >>> > > > > are
> >>> > > > > >> unique in that they can involve various different
native
> >>> language
> >>> > > > > changes.
> >>> > > > > >> This could require more than 1 committer needing
to review.
> >>> For
> >>> > > > example,
> >>> > > > > >> some committers are more experienced with android
vs ios, so
> >>> they
> >>> > > > won't
> >>> > > > > be
> >>> > > > > >> able to review the ios portion of the plugin
PR. Another
> issue
> >>> > with
> >>> > > > > plugin
> >>> > > > > >> PRs is that they may try to add a new feature
(without
> >>> discussion)
> >>> > > and
> >>> > > > > may
> >>> > > > > >> not add similar functionality for other platforms
that
> >>> support the
> >>> > > > > plugin.
> >>> > > > > >> And of course lots of PRs don't include tests.
> >>> > > > > >>
> >>> > > > > >> The name being attached to component doesn't
mean anything.
> >>> Issues
> >>> > > by
> >>> > > > > >> default go unassigned.
> >>> > > > > >>
> >>> > > > > >> I can only speak on behalf of the regular Adobe
cordova
> >>> commiters
> >>> > (4
> >>> > > > of
> >>> > > > > >> us). Our focus is usually spent on platforms
+ tools fixes
> and
> >>> > > > > >> improvements.
> >>> > > > > >>
> >>> > > > > >> The best way to get attention for your PR is
to post it to
> >>> slack +
> >>> > > > > here. I
> >>> > > > > >> usually do a review of PRs when I do a plugins
release, but
> I
> >>> > won't
> >>> > > be
> >>> > > > > >> able
> >>> > > > > >> to go through them all. This is why I ask for
people to
> bring
> >>> some
> >>> > > to
> >>> > > > my
> >>> > > > > >> attention during releases.
> >>> > > > > >>
> >>> > > > > >> Lastly, we would love to help onboard new committers
to help
> >>> > manage
> >>> > > > > >> plugins. If you are interested in such a role,
LMK!
> >>> > > > > >>
> >>> > > > > >> Cheers,
> >>> > > > > >> -Steve
> >>> > > > > >>
> >>> > > > > >> On Wed, Aug 24, 2016 at 6:14 AM, Scott Bradshaw
> >>> > > > > >> wrote:
> >>> > > > > >>
> >>> > > > > >> > Hi Steven - Can you look at camera PR
197
> >>> > > > > >> > ? This
> >>> > > > > >> addresses
> >>> > > > > >> > a major bug in the Android camera plugin
where it won't
> >>> rotate
> >>> > > > > pictures
> >>> > > > > >> > chosen from the library. This bug has
been around since
> >>> Android
> >>> > > 4.4
> >>> > > > > was
> >>> > > > > >> > released.  I worked on this at the beginning
of the year,
> >>> but
> >>> > it's
> >>> > > > > just
> >>> > > > > >> > sitting there.  I'm new to Cordova, so
I don't know
> exactly
> >>> what
> >>> > > the
> >>> > > > > >> > process is to get someone to look at it.
I've joined Slack
> >>> to
> >>> > find
> >>> > > > > >> someone
> >>> > > > > >> > to look at it, but no luck. Your name
appears to be a
> >>> attached
> >>> > > > > >> > > > com.atlassian.jira.jira-projec
> >>> ts-plugin:components-panel>
> >>> > > > > >> > to most of the plugins, including camera.
This also isn't
> >>> the
> >>> > only
> >>> > > > PR
> >>> > > > > >> out
> >>> > > > > >> > there for camera. Several are just sitting
there waiting
> for
> >>> > > review.
> >>> > > > > At
> >>> > > > > >> > what point do they get reviewed?
> >>> > > > > >> >
> >>> > > > > >> > On Wed, Aug 24, 2016 at 1:16 AM, Steven
Gill
> >>> > > > > >> > wrote:
> >>> > > > > >> >
> >>> > > > > >> > > Thoughts? Any PRs to bring to my
attention?
> >>> > > > > >> > >
> >>> > > > > >> > > Will aim to start it later this week.
> >>> > > > > >> > >
> >>> > > > > >> >
> >>> > > > > >>
> >>> > > > > >
> >>> > > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > > >
> >>> > > >
> >>> > >
> >>> >
> >>>
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message