cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-coho pull request #129: CB-11642 Update CDVAvailability.h
Date Wed, 28 Sep 2016 00:01:54 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/129#discussion_r80821223
  
    --- Diff: src/platform-release.js ---
    @@ -131,15 +133,15 @@ exports.prepareReleaseBranchCommand = function*() {
         var repos = flagutil.computeReposFromFlag(argv.r);
         var version = flagutil.validateVersionString(argv.version);
         var branchName = getVersionBranchName(version);
    -
    +    var platform = repos.id;
    --- End diff --
    
    this is the wrong way to get platform. Instead get it from the `repo.id` from within the
foreach below


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message