cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-coho pull request #139: CB-11909 changed prepare-release-branch comm...
Date Tue, 27 Sep 2016 23:48:00 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/139#discussion_r80819634
  
    --- Diff: src/platform-release.js ---
    @@ -128,14 +127,32 @@ exports.prepareReleaseBranchCommand = function*() {
                    '\n' +
                    'Usage: $0 prepare-release-branch --version=3.6.0 -r platform')
         );
    +   
         var repos = flagutil.computeReposFromFlag(argv.r);
    -    var version = flagutil.validateVersionString(argv.version);
    -    var branchName = getVersionBranchName(version);
    +    var branchName = null;
    + 
     
         // First - perform precondition checks.
         yield repoupdate.updateRepos(repos, [], true);
     
         yield repoutil.forEachRepo(repos, function*(repo) {
    +       
    +        var version = null;
    +
    +        if (argv.version === undefined) {
    +            // Grabbing version from platformPackageJson
    --- End diff --
    
    Great! I'll merge it in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message