cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imhotep <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #490: Android studio
Date Thu, 22 Sep 2016 23:04:13 GMT
Github user imhotep commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/490#discussion_r80154885
  
    --- Diff: cordova-lib/src/platforms/platforms.js ---
    @@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {
                 events.emit('warn', ' Using this version of Cordova with older version of
cordova-' + platform +
                     ' is being deprecated. Consider upgrading to cordova-' + platform + '@'
+
                     platforms[platform].apiCompatibleSince + ' or newer.');
    +        } else {
    +            events.emit('warn', 'Error loading cordova-'+platform);
    --- End diff --
    
    Not a lot. However, whenever there is something wrong with the `PlatformApi`, the error
that gets displayed to the user is indicating that they have the wrong version of the platform.
In reality though, something could be wrong with the `PlatformApi` code which can be **super**
misleading, hence the change. This is a very small change that can help immensely with debugging
and troubleshooting errors related to `PlatformApi` code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message