cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ephemer <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...
Date Wed, 21 Sep 2016 21:57:46 GMT
Github user ephemer commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/187
  
    @manucorporat the term is reference counted and deinited / cleaned up. "Garbage Collection"
sounds like heresy to my ears, but the principles are somewhat similar, so you're forgiven
:)
    
    I did some tests and confirmed that the UIWindow does get deinited as soon as its view
controllers are dismissed. I didn't test whether this actually fixes the OAuth issue in WKWebView,
but I'll take your word for it.
    
    I'd change the names to at least `dummyWindow` and `dummyViewController`, I found it kind
of confusing as is. Otherwise it's a big 👍  from me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message