cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #195: CB-11836 Allow setting of 'ForegroundText...
Date Wed, 21 Sep 2016 10:40:56 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/195#discussion_r79803408
  
    --- Diff: template/cordova/lib/AppxManifest.js ---
    @@ -390,11 +390,6 @@ AppxManifest.prototype.getVisualElements = function () {
             },
             setForegroundText: function (color) {
                 if (color) {
    --- End diff --
    
    Instead of `if (color) { visualElements.attrib.ForegroundText = color; }` would it be
better to use `visualElements.attrib.ForegroundText = color || 'light'` so that ForegroundText
would be reset as default `light` if we set `dark` via preference for example and then remove
the preference from config.xml entirely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message