cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tsschaffert <...@git.apache.org>
Subject [GitHub] cordova-windows issue #195: CB-11836 Allow setting of 'ForegroundText' prope...
Date Wed, 21 Sep 2016 10:08:39 GMT
Github user tsschaffert commented on the issue:

    https://github.com/apache/cordova-windows/pull/195
  
    1) The issue with Windows 10 should be fixed now, I handled it similarly to the 'ToastCapable'
property.
    2) The color argument is now passed to the manifest file unchecked, so invalid values
return an error like 'App manifest validation failed.' when building the project. Alternatively,
we could throw a TypeError for invalid values?
    3) I added only a very basic test, as there were no comparable tests for the visualElement
methods and I don't know enough about the internals to write really meaningful tests



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message