cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #490: Android studio
Date Fri, 16 Sep 2016 22:54:56 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/490#discussion_r79263894
  
    --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
    @@ -193,6 +193,11 @@ function resolveConfigFilePath(project_dir, platform, file) {
             return filepath;
         }
     
    +    // FIXME android studio
    +    if(platform === 'android' && !fs.existsSync(filepath)) {
    --- End diff --
    
    Can you put a comment here to describe how this works and why it is needed.
    It looks to me like if we are looking for config.xml and platform is android, the `return
filepath;` call on ln:193 is going to return before ever getting here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message