cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boosten <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs issue #82: Make sure the alert buttonLabel is a strin...
Date Fri, 09 Sep 2016 06:47:10 GMT
Github user Boosten commented on the issue:

    https://github.com/apache/cordova-plugin-dialogs/pull/82
  
    In case the "buttonLabel" is not a string, the native iOS implementation `showDialogWithMessage`
will crash on the `addAction` method because `actionWithTitle` expects a string. 
    
    CDVNotification.m:
    `[alertController addAction:[UIAlertAction actionWithTitle:[buttons objectAtIndex:n]
                                                                    style:UIAlertActionStyleDefault
                                                                  handler:^(UIAlertAction
* action)`
    
    **result:**
    `-[__NSCFNumber isEqualToString:]: unrecognized selector sent to instance`
    
    So I think it's not superfluous to check whether or not the passed in button is a string.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message