cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs issue #82: Make sure the alert buttonLabel is a strin...
Date Fri, 09 Sep 2016 01:05:06 GMT
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-plugin-dialogs/pull/82
  
    I think we are okay with 
    ``` 
        alert("What is the meaning of life?", function(){}, "Your Question", 42);
    ```
    also, your code overlooks empty string ... ( "" || "OK") returns OK, but typeof "" IS
string.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message