cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar pull request #62: CB:-9161 Support iPad multitaskin...
Date Thu, 01 Sep 2016 12:36:15 GMT
Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/62#discussion_r77164722
  
    --- Diff: src/ios/CDVStatusBar.m ---
    @@ -132,13 +132,15 @@ - (void)pluginInitialize
     
         // blank scroll view to intercept status bar taps
         self.webView.scrollView.scrollsToTop = NO;
    -    UIScrollView *fakeScrollView = [[UIScrollView alloc] initWithFrame:UIScreen.mainScreen.bounds];
    +    
    +    CGRect bounds = [self.viewController.view.window bounds];
    --- End diff --
    
    Probably on pluginInitialize the viewController isn't initialized yet and that's why you
get (0,0)x(0,0)
    
    I think we can keep the UIScreen.mainScreen.bounds here as the fakeScrollView is a non
visible UIScrollView that is bigger than the actual screen, and that is still true on multitasking
mode.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message