Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: daserge <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-180-cordova-plugin-inappbrowser@git.apache.org>
Subject: [GitHub] cordova-plugin-inappbrowser pull request #180: CB-10973 inAppBrowser for Win...
Content-Type: text/plain
Date: Fri, 19 Aug 2016 14:46:07 +0000 (UTC)
archived-at: Fri, 19 Aug 2016 14:46:09 -0000

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/180

    CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…

    …ith location=yes
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Removes a transparent gap between x-ms-webview and bottom appbar.
    
    ### What testing has been done on this change?
    Windows 8.1/10, Windows Phone 8.1/10, normal and fullscreen modes, portrait and landscape orientations.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-10973)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #180
    
----
commit a77b289f0132e71f635cf692d816c47d42efe972
Author: daserge <v-seshak@microsoft.com>
Date:   2016-08-19T14:43:48Z

    CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org