Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
MIME-Version: 1.0
In-Reply-To: <CDBD9B57-AFA8-4C28-BA61-C9E664F558D0@sap.com>
References: <D4322C16-3A25-4CFB-909E-62D732DCDFC2@sap.com> <CDBD9B57-AFA8-4C28-BA61-C9E664F558D0@sap.com>
From: julio cesar sanchez <jcesarmobile@gmail.com>
Date: Tue, 30 Aug 2016 23:20:00 +0200
Message-ID: <CAG5ZNwUq9gmU=c8uY7peEhwnZ1rUcEO-q-qhbx80isu-2NuU_g@mail.gmail.com>
Subject: Re: Cordova bridge call exception console log does not include call
 stack information
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=001a114b41202f9c7c053b508b99
archived-at: Tue, 30 Aug 2016 21:20:09 -0000

--001a114b41202f9c7c053b508b99
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi.

Can you create an issue on issues.cordova.io?

El martes, 30 de agosto de 2016, Li, Jonathan <jonathan.li@sap.com>
escribi=C3=B3:

>
> Hi,
> In cordova.js, callbackFromNative method, when handles the exception, it
> only logs the callbackid and error message, but does not log the error
> callstack. Usually the callstack is quite useful to find what causes the
> exception, so just wonder what is the reason to not include it in the err=
or
> console log.
>
> If it is fine to include the call stack information in the console log, I
> would like to submit a pull request for the change.
>
>
>   /**
>      * Called by native code when returning the result from an action.
>      */
>     callbackFromNative: function(callbackId, isSuccess, status, args,
> keepCallback) {
>         try {
>             var callback =3D cordova.callbacks[callbackId];
>             if (callback) {
>                 if (isSuccess && status =3D=3D cordova.callbackStatus.OK)=
 {
>                     callback.success && callback.success.apply(null, args=
);
>                 } else if (!isSuccess) {
>                     callback.fail && callback.fail.apply(null, args);
>                 }
>                 /*
>                 else
>                     Note, this case is intentionally not caught.
>                     this can happen if isSuccess is true, but
> callbackStatus is NO_RESULT
>                     which is used to remove a callback from the list
> without calling the callbacks
>                     typically keepCallback is false in this case
>                 */
>                 // Clear callback if not expecting any more results
>                 if (!keepCallback) {
>                     delete cordova.callbacks[callbackId];
>                 }
>             }
>         }
>         catch (err) {
>             var msg =3D "Error in " + (isSuccess ? "Success" : "Error") +=
 "
> callbackId: " + callbackId + " : " + err;
>             console && console.log && console.log(msg);
>             cordova.fireWindowEvent("cordovacallbackerror", { 'message':
> msg });
>             throw err;
>         }
>
> Thanks
> Jonathan
>

--001a114b41202f9c7c053b508b99--