Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dotNetkow <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-162-cordova-plugin-inappbrowser@git.apache.org>
In-Reply-To: <git-pr-162-cordova-plugin-inappbrowser@git.apache.org>
Subject: [GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...
Content-Type: text/plain
Message-Id: <20160828200416.AFBD7DFE2C@git1-us-west.apache.org>
Date: Sun, 28 Aug 2016 20:04:16 +0000 (UTC)
archived-at: Sun, 28 Aug 2016 20:04:18 -0000

Github user dotNetkow commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/162
  
    hi @shazron - any way your team could consider this? OAuth is a major reason folks use InAppBrowser, and for years now it's been feasible and "supported" in a sense with UIWebView.  
    
    One alternative is to use the "toolbar=yes" option, which shows a "done" link that will close the browser.  Developer's would have to have a self hosted page that tells the user to tap the link, like "Successfully connected! Please tap Done to continue".  Not the best usability but possible:
    
    `inAppBrowserRef = window.open("www.google.com", '_blank', 'toolbar=yes');`
    
    However, I once had Apple reject my app with this option in place - they didn't like that it obviously loading "something" outside of my app.  So that's probably out :(
    
    Thanks for considering.  The performance gains from WKWebView are immense, so I'd hate to miss out on using it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org