cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahirun0426 <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #484: [CB-11730] Modify condition of if clause to a...
Date Mon, 22 Aug 2016 07:49:12 GMT
GitHub user ahirun0426 opened a pull request:

    https://github.com/apache/cordova-lib/pull/484

    [CB-11730] Modify condition of if clause to avoid similar project nam…

    …e with plugin name
    
    The original if clause accepts 
     c:\work\SimplePlugin_TestBed with c:\work\SimplePlugin
    
    So I add \ to the plugin directory name for only enable the if clause to complete match
the directory name.
     c:\work\SimplePlugin\
    
    nodejs.org description explains the path.resolve removes trailing slashes, the code should
work with the situation.
    
    https://nodejs.org/dist/latest-v6.x/docs/api/path.html#path_path_resolve_path
    'The resulting path is normalized and trailing slashes are removed unless the path is
resolved to the root directory.'

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahirun0426/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #484
    
----
commit ea2759a477045238b34fcacee14fcc0e1aea6162
Author: yseki <yasuharu.seki@jp.sony.com>
Date:   2016-08-22T07:40:31Z

    [CB-11730] Modify condition of if clause to avoid similar project name with plugin name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message