cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #245: CB-11731 Re-read ios.json on every prepare
Date Tue, 30 Aug 2016 12:16:45 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-ios/pull/245

    CB-11731 Re-read ios.json on every prepare

    This fixes empty 'ios.json' file after calling a sequence of `'prepare' -> 'addPlugin'
-> 'prepare'` within one node process. A typical scenario when this might happen is installing
ios platform into project with other platforms (and plugins) already installed. Then logic
in ios' `prepare` caches `PlatformJson` instance and overrides all changes to ios.json, made
during plugin installation in second `prepare`
    
    Related JIRA: [CB-11731](https://issues.apache.org/jira/browse/CB-11731)
    This also might be a real reason of [CB-11589](https://issues.apache.org/jira/browse/CB-11589)
and https://github.com/apache/cordova-lib/pull/464
    
    @stevengill, @dpogue, please take a look

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-ios CB-11731

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #245
    
----
commit 2085ab9273befbe1187840c309fd8f4e7ad9ed28
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2016-08-30T10:48:48Z

    CB-11731 Re-read ios.json on every prepare

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message