cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DisruptiveMind <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #232: CB-11714: (windows) added more expl...
Date Sun, 21 Aug 2016 21:52:55 GMT
GitHub user DisruptiveMind opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/232

    CB-11714: (windows) added more explicit content-type when converting …

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds an explicit check for PNG/JPEG to set the content type when converting to target
data URL in resizeImage()
    
    ### What testing has been done on this change?
    Manual testing has been done using a Windows 10 Desktop.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    …nvas

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DisruptiveMind/cordova-plugin-camera CB-11714

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #232
    
----
commit 6833cd17523392751c6962562d9d7dd392550f0f
Author: Tyler Pham <tyler@disruptiveart.com>
Date:   2016-08-21T21:50:35Z

    CB-11714: (windows) added more explicit content-type when converting to target data on
canvas

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message