cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mhartington <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...
Date Thu, 11 Aug 2016 19:25:44 GMT
GitHub user mhartington opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/229

    CB-11661: (ios) Add mandatory iOS 10 privacy description

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Adds the mandatory NSCameraUsageDescription key to the info.plist, allowing to pass the
value as a variable.
    Documented the usage of the variable on plugin install as iOS quirk
    
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mhartington/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #229
    
----
commit 8ead470d752fdc50f3d315fb3aeb3fa709ce3f45
Author: mhartington <mikehartington@gmail.com>
Date:   2016-08-11T19:22:39Z

    CB-11661: (ios) Add mandatory iOS 10 privacy description

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message