cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bisrael <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #228: add CAMERA and READ_EXTERNAL_STORAG...
Date Tue, 09 Aug 2016 23:56:07 GMT
GitHub user bisrael opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/228

    add CAMERA and READ_EXTERNAL_STORAGE permissions to the manifest file…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    … so they can be enabled/disabled in the application manager settings for the application
(plus they are requested at runtime now too).
    
    fixes CB-11689

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bisrael/cordova-plugin-camera bisrael/add-uses-permissions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #228
    
----
commit 5af4ea5a13621dc5420b7d6498b306a15bf8e49f
Author: bisrael <blake.israel@gatech.edu>
Date:   2016-08-09T23:48:35Z

    add CAMERA and READ_EXTERNAL_STORAGE permissions to the manifest file so they can be enabled/disabled
in the application manager settings for the application (plus they are requested at runtime
now too).
    
    fixes CB-11689

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message