cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #192: CB-11657 Add bom to www after plugin oper...
Date Wed, 10 Aug 2016 10:31:56 GMT
GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-windows/pull/192

    CB-11657 Add bom to www after plugin operations

    JIRA [CB-11657](https://issues.apache.org/jira/browse/CB-11657)
    
    This PR addresses WACK validation issues when app has been built from VS after installing/restoring
plugins. In this case some files, added by plugins would not have BOM

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimir-kotikov/cordova-windows CB-11657

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit 455bf4b62683ab380904f2e78eebe77d4a7fdb5c
Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
Date:   2016-08-10T10:04:24Z

    CB-11657 Add bom to www after plugin operations
    
    Since cordova is not calling `prepare` immediately after plugin
    has been installed/removed, we need to take care of adding BOM ourselves.
    Otherwise user can run into situation when project, built from Visual
    Studio immediately after installation/removal of plugin, will not pass
    WACK tests due to missing BOM in some files.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message