cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From matrosovN <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #190: CB-11693 ios: Make execution callback...
Date Tue, 16 Aug 2016 07:20:17 GMT
GitHub user matrosovN opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/190

    CB-11693 ios: Make execution callback within doCopyMove method in the…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    ios
    
    ### What does this PR do?
    Callback within doCopyMove method was executed in main thread. PR lets to avoid 'THREAD
WARNING' message, because it makes callback  execution in the background thread.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    … background thread

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matrosovN/cordova-plugin-file CB-11693

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #190
    
----
commit 66100807aca21b08ffef22ec8d1b85fb5195349a
Author: Nikita Matrosov <nikita.matrosov@rp.ru>
Date:   2016-08-16T07:07:39Z

    CB-11693 ios: Make execution callback within doCopyMove method in the background thread

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message