cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GavinPacini <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #183: CB-11783: (android) Add inten...
Date Mon, 29 Aug 2016 15:37:28 GMT
GitHub user GavinPacini opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/183

    CB-11783: (android) Add intent scheme to be handled by OS

    ### Platforms affected
    Android
    
    ### What does this PR do?
    The intent scheme `intent://` is [recommended by Google ](https://developer.chrome.com/multidevice/android/intents)
for launching apps. Cordova should forward this to the OS to handle appropriately.
    
    ### What testing has been done on this change?
    Intent is forwarded to the OS and provides the application handler dialog for the user
to select an app.
    
    ### Checklist
    - [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GavinPacini/cordova-plugin-inappbrowser patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit df084ff869cc33213171f4ffaef01c54838a472a
Author: Gavin Pacini <gavinpacini@users.noreply.github.com>
Date:   2016-08-29T15:20:12Z

    Add intent scheme to be handled by OS
    
    The intent scheme `intent://` is [recommended by Google ](https://developer.chrome.com/multidevice/android/intents)
for launching apps. Cordova should forward this to the OS to handle appropriately.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message