cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #179: CB-11013 IAB enabling backgro...
Date Tue, 16 Aug 2016 18:25:19 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/179

    CB-11013 IAB enabling background play of YouTube videos?

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Adds ShouldPauseInAppBrowser preference to stop backgound audio to avoid Google Play issue:
    "Make sure your app doesn’t access or use a service or API in a manner that violates
its terms of service, for example, by enabling background play of YouTube videos."
    
    ### What testing has been done on this change?
    Manual testing on Android 5.0.1
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-11013)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-11013

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit b50de96d48c0a48d7df65cbef97ccfe3878fbc8a
Author: daserge <v-seshak@microsoft.com>
Date:   2016-08-16T18:22:32Z

    CB-11013 IAB enabling background play of YouTube videos?
    
    Adds ShouldPauseInAppBrowser preference to stop backgound audio

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message