cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #178: CB-10467 Hardware back button...
Date Tue, 16 Aug 2016 17:17:23 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/178

    CB-10467 Hardware back button, while InAppBrowser is opened, closes t…

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    …he app too in addition to closing InAppBrowser
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-10467)
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds the same backbutton handling behavior to Windows as Android platform has, i.e. if
`hardwareback=yes` (by default) we navigate history back and then close inappbrowser, and
just close iab if `hardwareback=no`.
    
    ### What testing has been done on this change?
    Tested on Windows 8.1/10 and Phone 8.1/10.
    backbutton event is not fired in a Windows 8.1 project on Windows 10 host OS; otherwise
all works ok.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10467

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 3f180ffa96ac345384e31fd52a479517a14f4000
Author: daserge <v-seshak@microsoft.com>
Date:   2016-08-16T17:10:15Z

    CB-10467 Hardware back button, while InAppBrowser is opened, closes the app too in addition
to closing InAppBrowser

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message